Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add Pickaxes to Progressive Tools in Minecraft info page #2688

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Docs: Add Pickaxes to Progressive Tools in Minecraft info page #2688

merged 2 commits into from
Mar 8, 2024

Conversation

Seatori
Copy link
Contributor

@Seatori Seatori commented Jan 8, 2024

What is this fixing or adding?

Adds the Stone Pickaxe, Iron Pickaxe, and Diamond Pickaxe to their respective levels of Progressive Tools on the Minecraft info page.

How was this tested?

Checked the code for the mod and confirmed that the respective levels of Progressive Tools are required to craft each Pickaxe.

@Seatori Seatori requested a review from KonoTyran as a code owner January 8, 2024 12:03
@ScipioWright ScipioWright added the is: documentation Improvements or additions to documentation. label Jan 9, 2024
nicholassaylor
nicholassaylor approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. not sure why it was missing before as it is the most important upgrade in the progression

Exempt-Medic
Exempt-Medic approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Exempt-Medic Exempt-Medic added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Mar 7, 2024
@Exempt-Medic
Copy link
Member

@KonoTyran @espeon65536 (Just so you know this exists)

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Mar 7, 2024
@KonoTyran KonoTyran merged commit 3e3b4c6 into ArchipelagoMW:main Mar 8, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Seatori @EmilyV99
Minecraft: Add Pickaxes to the documentation (ArchipelagoMW#2688)
b686fc6
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Seatori @EmilyV99
Minecraft: Add Pickaxes to the documentation (ArchipelagoMW#2688)
96d9424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonoTyran KonoTyran KonoTyran approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@nicholassaylor nicholassaylor nicholassaylor approved these changes

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Seatori @Exempt-Medic @KonoTyran @nicholassaylor @ScipioWright