Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: fix start_inventory_from_pool only adding one filler per item name #2185

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

https://discord.com/channels/731205301247803413/1152413200067854407

How was this tested?

I joinked the Subnautica yaml, wrote the assert, saw it trigger. Then wrote the fix and tested that the assert doesn't trigger anymore.

If this makes graphical changes, please attach screenshots.

Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked to fix the noted issue

@lordlou
Copy link
Contributor

lordlou commented Sep 16, 2023

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@Berserker66 Berserker66 merged commit ce8f07b into main Sep 16, 2023
@Berserker66 Berserker66 deleted the core_fix_start_inventory_from_pool_amount branch September 16, 2023 16:07
@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: core Issues/PRs that touch core and may need additional validation. labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants