Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Test that a world can generate with item links #2081

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Moves Item Link creation out of main; there's likely a better place but this is what made the most sense to me. Also adds a unit test for generating with full item link replacements. Since most worlds generate filler randomly, that filler won't actually get replaced, so unsure on how to best add actual tests beyond "doesn't crash".

@el-u
Copy link
Collaborator

el-u commented Aug 10, 2023

I'm not sure how much value this actually adds since it isn't really testing anything beyond "it generates", but done.

Regarding added value:
The test now shows that there are a bunch of world types that only fail if replacement items are also linked. We already knew this for Messenger and Lufia II (see #2083), but for the other worlds that seems to be new and potentially useful information.

Regarding doing nothing beyond "it generates":
Would it make sense to assertBeatable?

@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels Aug 16, 2023
@alwaysintreble
Copy link
Collaborator Author

alwaysintreble commented Nov 27, 2023

Currently failing worlds:

all of the self.random issues are addressed in #2083, so for the relevant people this is just for notification and to confirm that 2083 solves those worlds. Messenger and L2AC have already been tested fixed with 2083.

@alwaysintreble alwaysintreble added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 14, 2024
@ScipioWright ScipioWright added the waiting-on: other Issue/PR is waiting for something else, like another PR. label Jun 3, 2024
@NewSoupVi
Copy link
Member

NewSoupVi commented Nov 28, 2024

The only remaining fails are SMZ3 and Pokemon RB.

A PR for SMZ3 has been opened: #4099
A PR for Pokemon RB has not.

Since it has been long enough, I will ping @Alchav again here. We really want to merge this unit test asap if possible and Pokemon RB is failing it.
Will probably ping in the Discord on Monday or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: other Issue/PR is waiting for something else, like another PR. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants