-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Test that a world can generate with item links #2081
base: main
Are you sure you want to change the base?
Tests: Test that a world can generate with item links #2081
Conversation
a230f45
to
c7875c0
Compare
Regarding added value: Regarding doing nothing beyond "it generates": |
# Conflicts: # BaseClasses.py
# Conflicts: # Main.py # test/general/test_items.py
Currently failing worlds:
all of the self.random issues are addressed in #2083, so for the relevant people this is just for notification and to confirm that 2083 solves those worlds. Messenger and L2AC have already been tested fixed with 2083. |
# Conflicts: # Main.py # test/general/test_items.py
The only remaining fails are SMZ3 and Pokemon RB. A PR for SMZ3 has been opened: #4099 Since it has been long enough, I will ping @Alchav again here. We really want to merge this unit test asap if possible and Pokemon RB is failing it. |
What is this fixing or adding?
Moves Item Link creation out of main; there's likely a better place but this is what made the most sense to me. Also adds a unit test for generating with full item link replacements. Since most worlds generate filler randomly, that filler won't actually get replaced, so unsure on how to best add actual tests beyond "doesn't crash".