TLoZ: fix LauncherComponents entry #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
the
is: bug/fix
|
Looks straight forward, but look at it first <3. |
|
yeah i was working with wqferr on this |
t3hf1gm3nt
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
shown to be working from this discord message https://discord.com/channels/731205301247803413/1090821869340467332/1123763145433940041
ThePhar
approved these changes
Jun 29, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The LauncherComponents entry for TLoZ didn't include a file suffix identifier, which forbade the file picker from selecting
.aptlozfiles in some platforms.How was this tested?
This was not tested, since it could only be reproduced in a Linux machine and none of the devs have one ready. This is a very simple change, and just double checking the spelling is correct should suffice.