Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: import Markup from markupsafe #1848

Merged
merged 3 commits into from
Jun 19, 2023
Merged

WebHost: import Markup from markupsafe #1848

merged 3 commits into from
Jun 19, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

DeprecationWarning: 'flask.Markup' is deprecated and will be removed in Flask 2.4. Import 'markupsafe.Markup' instead.

How was this tested?

I started the webhost.

If this makes graphical changes, please attach screenshots.

@black-sliver
Copy link
Member

black-sliver commented May 31, 2023

shouldn't we put markupsafe into WebHostLib/requirements.txt ?

@ThePhar ThePhar added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label May 31, 2023
@Berserker66
Copy link
Member Author

maybe? I figured it comes with werkzeug?

@Berserker66 Berserker66 merged commit a75159b into main Jun 19, 2023
@Berserker66 Berserker66 deleted the webhost_markup branch June 19, 2023 23:01
Witchybun pushed a commit to Witchybun/Archipelago that referenced this pull request Jun 26, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants