This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Load gRPC methods whenever selecting a new request #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
After debugging this, it seems to me the issue was that the methods were only loaded for the request that happened to be selected at startup. This caused the method selection and request body to be broken for all other requests.
This PR changes request loading so that gRPC methods are loaded whenever the GrpcRequestPane is opened for a new gRPC request.
This whole loading of proto methods is pretty inefficient, it writes the proto file to temporary storage and re-parses it every time a request is selected. This could be improved by trivially adding a little cache in ipc/grpc that memoizes these results, but the downside is that users would then have to explicitly reload the protos every time they change.