This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Add abstraction of the database + add FS implementation #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is PoC for the issue #24 (part of the Roadmap #13)
The PR is far from complete, and the approach is a bit naive.
The idea is to have an interface that implement all functions that Insonimum use to communicate with the Database based on the Insomnia real usage.
Make an implementation with NeDB to check that Insonimum is still running.
Then make a new implementation that use Node FS module.
So far, it's seem to work, but I don't cover all use case.
And some unit tests are also failing
We can even push the idea a bit further bit and implements 2 new databases: a Primary/Replica database (a simple implementation that forward all call to several other implementations) and a Git implementation
With this, we can achieve seamless Git synchronization