Ensure latest peerDependencies are checked #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking `peerDependencies` if a package is found to have
dependencies query npm for the current versions. If the latest version
allowed by the current range is greater than the installed version query
NPM for the `peerDependencies` list instead of using the local
`package.json`. This ensures that newer allowed version's requirements
are met.
There are two edge cases where this isn't correct:
* A newer version is released that satisfies the current range and adds
`peerDependencies` to a package that previously didn't have any.
* This is unlikely to be hit in practice as that should generally
require a bump out of most client dependency ranges of the package.
* The locally installed package isn't up to date so NPM is queried, but
NPM has a version that is outside the allowed range of the package.
* NPM has no way of querying a specific version's `peerDependencies`
so this can't be fixed unfortunately.
Fixes #7
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking
peerDependenciesif a package is found to have dependencies query npm for the current versions. If the latest version allowed by the current range is greater than the installed version query NPM for thepeerDependencieslist instead of using the localpackage.json. This ensures that newer allowed version's requirements are met.There are two edge cases where this isn't correct:
peerDependenciesto a package that previously didn't have any.peerDependenciesso this can't be fixed unfortunately.Fixes #7.