Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate forcing the user to update the schema in transactions #130

Closed
lvca opened this issue Oct 12, 2021 · 1 comment
Closed

Evaluate forcing the user to update the schema in transactions #130

lvca opened this issue Oct 12, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@lvca
Copy link
Contributor

lvca commented Oct 12, 2021

Schema updates don't require a transaction, because when a transactional operation is required, a new (sub) transaction is created. Also, with the last changes, in order to replicate the creation of indexes, we needed to both listen for file changes and page changes. The solution was to embed a database change structure request in the TxRequest object.

Evaluate if makes sense to force the user to open a transaction for any schema changes. In this way, we could simplify the current workflow and store database changes ONLY in the TxRequest object.

@lvca lvca self-assigned this Oct 12, 2021
@lvca lvca added the enhancement New feature or request label Oct 12, 2021
@lvca
Copy link
Contributor Author

lvca commented Nov 16, 2021

We don't need this, more consistent and predictable to have their own TX for schema updates.

@lvca lvca closed this as completed Nov 16, 2021
@lvca lvca added the invalid This doesn't seem right label Nov 16, 2021
mergify bot added a commit that referenced this issue Jan 13, 2025
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3.2.0 to 3.3.0.
Release notes

*Sourced from [docker/setup-qemu-action's releases](https://github.com/docker/setup-qemu-action/releases).*

> v3.3.0
> ------
> 
> * Add `cache-image` input to enable/disable caching of binfmt image by [`@​crazy-max`](https://github.com/crazy-max) in [docker/setup-qemu-action#130](https://redirect.github.com/docker/setup-qemu-action/pull/130)
> * Bump `@​actions/core` from 1.10.1 to 1.11.1 in [docker/setup-qemu-action#172](https://redirect.github.com/docker/setup-qemu-action/pull/172)
> * Bump `@​docker/actions-toolkit` from 0.35.0 to 0.49.0 in [docker/setup-qemu-action#187](https://redirect.github.com/docker/setup-qemu-action/pull/187)
> * Bump cross-spawn from 7.0.3 to 7.0.6 in [docker/setup-qemu-action#182](https://redirect.github.com/docker/setup-qemu-action/pull/182)
> * Bump path-to-regexp from 6.2.2 to 6.3.0 in [docker/setup-qemu-action#162](https://redirect.github.com/docker/setup-qemu-action/pull/162)
> 
> **Full Changelog**: <docker/setup-qemu-action@v3.2.0...v3.3.0>


Commits

* [`53851d1`](docker/setup-qemu-action@53851d1) Merge pull request [#187](https://redirect.github.com/docker/setup-qemu-action/issues/187) from docker/dependabot/npm\_and\_yarn/docker/actions-to...
* [`7066b90`](docker/setup-qemu-action@7066b90) chore: update generated content
* [`7559081`](docker/setup-qemu-action@7559081) build(deps): bump `@​docker/actions-toolkit` from 0.35.0 to 0.49.0
* [`08d11eb`](docker/setup-qemu-action@08d11eb) Merge pull request [#172](https://redirect.github.com/docker/setup-qemu-action/issues/172) from docker/dependabot/npm\_and\_yarn/actions/core-1.11.1
* [`e53506f`](docker/setup-qemu-action@e53506f) chore: update generated content
* [`610b442`](docker/setup-qemu-action@610b442) build(deps): bump `@​actions/core` from 1.10.1 to 1.11.1
* [`58a19f8`](docker/setup-qemu-action@58a19f8) Merge pull request [#182](https://redirect.github.com/docker/setup-qemu-action/issues/182) from docker/dependabot/npm\_and\_yarn/cross-spawn-7.0.6
* [`49a12c4`](docker/setup-qemu-action@49a12c4) Merge pull request [#180](https://redirect.github.com/docker/setup-qemu-action/issues/180) from docker/dependabot/github\_actions/codecov/codecov...
* [`2b8ac83`](docker/setup-qemu-action@2b8ac83) ci: fix deprecated input for codecov-action
* [`fdbeaac`](docker/setup-qemu-action@fdbeaac) Merge pull request [#130](https://redirect.github.com/docker/setup-qemu-action/issues/130) from crazy-max/cache-image
* Additional commits viewable in [compare view](docker/setup-qemu-action@49b3bc8...53851d1)

  

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=docker/setup-qemu-action&package-manager=github\_actions&previous-version=3.2.0&new-version=3.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant