Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ngs module to address bug #93

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

isabelleliuu
Copy link
Contributor

replace str.lengths with str.len_bytes using ppolars version 1.4.0

@abearab
Copy link
Collaborator

abearab commented Sep 11, 2024

@aidanwinters

@nick-youngblut nick-youngblut merged commit 299749e into ArcInstitute:master Sep 11, 2024
3 checks passed
@@ -195,7 +195,7 @@ def get_counts_matrix(self, fastq_dir, samples, get_recombinant=False, cas_type=
if get_recombinant:
raise ValueError("Recombinants are not applicable for single guide design!")
if protospacer_length == 'auto':
protospacer_length = self.library['protospacer'].str.lengths().unique().to_list()[0]
protospacer_length = self.library['protospacer'].str.len_bytes().unique().to_list()[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabelleliuu – is this specific after an specific polars version? It would be helpful if we specify version (e.g. polars>=*.*)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abearab based on the polars github releases ([https://github.com/pola-rs/polars/releases/tag/py-0.19.8]) this change was made with the Python Polars 0.19.8 release

abearab added a commit that referenced this pull request Sep 22, 2024
related to #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants