fix - Fixed warning illustration in standalone ana...

...lyzers --- We shouldn't illustrate warnings as "failures" just because they get printed as red. We've changed the message to align with the warning more appropriately. --- Type: fix Breaking: False Doc Required: False Backport Required: False Part: 1/1
Aptivi · Sep 9, 2024 · 0461c38 · 0461c38
1 parent 643f995
commit 0461c38
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/private/Nitrocid.LocaleCheckerStandalone/EntryPoint.cs b/private/Nitrocid.LocaleCheckerStandalone/EntryPoint.cs
@@ -18,6 +18,7 @@
 //
 
 using Microsoft.Build.Locator;
+using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.MSBuild;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
@@ -53,7 +54,12 @@ static async Task Main()
                 // Create a workspace using the instance
                 using var workspace = MSBuildWorkspace.Create();
                 workspace.WorkspaceFailed += (o, e) =>
-                    TextWriterColor.WriteColor($"Failed to load the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Red);
+                {
+                    if (e.Diagnostic.Kind == WorkspaceDiagnosticKind.Warning)
+                        TextWriterColor.WriteColor($"Warning while loading the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Yellow);
+                    else
+                        TextWriterColor.WriteColor($"Failed to load the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Red);
+                };
 
                 // Check for Nitrocid solution
                 var solutionPath = "../../../../../Nitrocid.sln";

diff --git a/private/Nitrocid.LocaleClean/EntryPoint.cs b/private/Nitrocid.LocaleClean/EntryPoint.cs
@@ -18,6 +18,7 @@
 //
 
 using Microsoft.Build.Locator;
+using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.MSBuild;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
@@ -53,7 +54,12 @@ static async Task Main()
                 // Create a workspace using the instance
                 using var workspace = MSBuildWorkspace.Create();
                 workspace.WorkspaceFailed += (o, e) =>
-                    TextWriterColor.WriteColor($"Failed to load the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Red);
+                {
+                    if (e.Diagnostic.Kind == WorkspaceDiagnosticKind.Warning)
+                        TextWriterColor.WriteColor($"Warning while loading the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Yellow);
+                    else
+                        TextWriterColor.WriteColor($"Failed to load the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Red);
+                };
 
                 // Check for Nitrocid solution
                 var solutionPath = "../../../../../Nitrocid.sln";

diff --git a/public/Nitrocid.Analyzers/Nitrocid.StandaloneAnalyzer/EntryPoint.cs b/public/Nitrocid.Analyzers/Nitrocid.StandaloneAnalyzer/EntryPoint.cs
@@ -18,6 +18,7 @@
 //
 
 using Microsoft.Build.Locator;
+using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.MSBuild;
 using System;
 using System.IO;
@@ -51,7 +52,12 @@ static async Task Main(string[] args)
                 // Create a workspace using the instance
                 using var workspace = MSBuildWorkspace.Create();
                 workspace.WorkspaceFailed += (o, e) =>
-                    TextWriterColor.WriteColor($"Failed to load the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Red);
+                {
+                    if (e.Diagnostic.Kind == WorkspaceDiagnosticKind.Warning)
+                        TextWriterColor.WriteColor($"Warning while loading the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Yellow);
+                    else
+                        TextWriterColor.WriteColor($"Failed to load the workspace: [{e.Diagnostic.Kind}] {e.Diagnostic.Message}", true, ConsoleColors.Red);
+                };
 
                 // Load the solution
                 var solutionPath = args[0];