chore(deps): remove package-lock.json name property #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
approved these changes
Jan 5, 2025
|
I guess I could, alternatively, have added the name property to package.json. Eh, works either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to npm/cli#4608, a "name" property was added to the package-lock.json file by
npm audit fixin 01fe042 even thoughnpm installremoves it again.This commits the diff caused by running
npm install. Of course, if the linked issue gets resolved in the other direction (always creating a name property in package-lock.json based on the folder name if there is no name in package.json), this would be incorrect, but this is how it is at the moment. (Also, that wouldn't make much sense as a resolution, imho).Testing steps
n/a