Feat: Create js alias for root/app/js
#403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #77 Found the best explanation here: https://webpack.js.org/configuration/resolve/#resolvealias With this setting, all files and folders in js can now be referenced with the js alias, e.g. a module app/js/module.js should be imported in index.js as js/module.js. app/js/foo/hello.js should be imported in index.js as js/foo/hello.js.
path.resolve is necessary to make the alias work.
Lint should now use the same alias/path from webpack,
i.e. js=root/app/js.
parserOptions : {requireConfigFile: false}
This was set to false because reading modules from the
aliased path get an error about no babel config found.
import/no-extranesous-dependencies: warn
I had a path with a space in the folders, and that
triggerd an error that I should install the folder
via npm i folder-name.
This allows the use of js/ when refering to js scripts in app/js.
This is possible because of eslint-import-resolver-webpack.
|
Unfortunately I found some issues when testing this PR. Steps to reproduce:
This results in the following error (made slightly clearer after upgrading to ESLint 8.29.0): It seems to be an issue with Possible solutions:
It is unlikely that we'll do (1) soon, so I'm archiving this PR as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #77
How to test
app/jsor subdirectories inapp/js.app/jsusingjsalias. E.g. if module is inapp/js, usejs/name_of_module; if module is inapp/js/dir, usejs/dir/name_of_module.rhino::lint_js()andrhino::build_js()should work.