Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated checksum to match binary artifact #275

Closed
wants to merge 1 commit into from

Conversation

andibeqiri
Copy link

No description provided.

@JeremieDaigle2
Copy link

JeremieDaigle2 commented Apr 8, 2024

Anytime you guys are ready ! :D this is blocking
#276 (comment)
We cleared our caches, its still not working though

@galunecandrey
Copy link

Please consider this PR as soon as possible. We also have this problem on CI/CD. One of the packages we use has a dependency on AppsFlyerLib. Clearing caches doesn't help.

@JohnnyTseng
Copy link

@af-obodovskyi Would you please merge this PR? Thank you!

@srdanrasic
Copy link

@amit-kremer93 @af-obodovskyi could you look into this with urgency? This is breaking many organisation's CIs.

@JeremieDaigle2
Copy link

is there any good reason why this isnt merged in yet? this is blocking...

@hbanzon
Copy link

hbanzon commented Apr 9, 2024

Thank you for prepping this PR! I could benefit from it as well 🙏

@richroguetech
Copy link

Please merge this. I need this!

@af-obodovskyi
Copy link
Contributor

af-obodovskyi commented Apr 10, 2024

@richroguetech , @hbanzon , @srdanrasic , @JohnnyTseng

@scottlemke Please consider using one of the following repositories for the SPM. SPM support will be removed from the main repository because of the extremely long checkout time, which affects the SPM package integration time.

For statically linked library
https://github.com/AppsFlyerSDK/AppsFlyerFramework-Static

For dynamically linked library
https://github.com/AppsFlyerSDK/AppsFlyerFramework-Dynamic

For Strict (No IDFA colection) library
https://github.com/AppsFlyerSDK/AppsFlyerFramework-Strict

@ftp27
Copy link

ftp27 commented Apr 10, 2024

@af-obodovskyi what release processes are you talking about? It's just links to binaries and zero source code :D With the same result you can publish separate version tags in separate branches

@af-obodovskyi
Copy link
Contributor

@ftp27 not the release process, SPM package integration time. I will edit my comment

@richroguetech
Copy link

@af-obodovskyi can someone explain this? I used your repos and i got this:

. The /Frameworks/AppsFlyerLib.framework' specifies a MinimumOSVersion of '100.0' but contains a 32-bit architecture that is unsupported on iOS 12 and later.

Apple Developer Relations

@hbanzon
Copy link

hbanzon commented Apr 11, 2024

@af-obodovskyi I get the following error using the Static library. Seems liek there's some changes that will be required on our end if we switch repos.

AppsFlyerLib is not a valid configured external dependency

@hbanzon
Copy link

hbanzon commented Apr 11, 2024

Can we get more of a ramp up time to adapt to the new repos but in the meantime merge any of the PRs that fix this issue?

@scottlemke
Copy link

@af-obodovskyi I get the following error using the Static library. Seems liek there's some changes that will be required on our end if we switch repos.

AppsFlyerLib is not a valid configured external dependency

@hbanzon I assume you're using Tuist too? If so, you need to reference the static of dynamic library name to fix that issue. Something like:
.external(name: "AppsFlyerLib-Static") or .external(name: "AppsFlyerLib-Dynamic")

@hbanzon
Copy link

hbanzon commented Apr 11, 2024

Thank you @scottlemke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.