We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ChannelMode class' latter two comments (1, 2) are wrong.
An enum value with 0 adHocNetworkChannels and 0 cableCapacityFactor does not disable requirements, but rather limit the amount of used channels to 0.
See: with this setup and the following enum extension:
@Mixin(appeng.api.networking.pathing.ChannelMode.class) public class ChannelModeNoneEnumExtension { @Mutable @Shadow @Final private static appeng.api.networking.pathing.ChannelMode[] $VALUES; @Invoker(value = "<init>") private static appeng.api.networking.pathing.ChannelMode create(String name, int ordinal, int adHocNetworkChannels, int cableCapacityFactor){ throw new IllegalStateException(); } static { appeng.api.networking.pathing.ChannelMode NONE = create("NONE", $VALUES.length, 0, 0); $VALUES = ArrayUtils.add($VALUES, NONE); } }
I would correct this by simply removing the remark, since it's (clearly) not utilized.
The text was updated successfully, but these errors were encountered:
Fix #8022: Remove wrong documentation comments in ChannelMode
3a9ebba
I sure hope you aren't doing this kind of enum extension in production. 😄
Sorry, something went wrong.
0d3f023
They say ignorance is bliss, I hope you remain blissful on this matter.
No branches or pull requests
The ChannelMode class' latter two comments (1, 2) are wrong.
An enum value with 0 adHocNetworkChannels and 0 cableCapacityFactor does not disable requirements, but rather limit the amount of used channels to 0.
See:
![image](https://private-user-images.githubusercontent.com/25839246/347861897-815c8f3b-b0bb-445f-ac0c-7f42582c0a32.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NTc2MTEsIm5iZiI6MTcyNTU1NzMxMSwicGF0aCI6Ii8yNTgzOTI0Ni8zNDc4NjE4OTctODE1YzhmM2ItYjBiYi00NDVmLWFjMGMtN2Y0MjU4MmMwYTMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDE3MjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEyOTNhYjk4Mzk2ZTVjZGU3YzU0ZDUyYjQ5ODg1YTQ5NTZlZTliMGZjMzNkODAzNWM4YjI0YTM5YmYxYmU2ZTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.RJbYMdT8gSasJDdzlyq4rwafh6-igYrT_G5gOCNm4AM)
![image](https://private-user-images.githubusercontent.com/25839246/347862105-39d7607b-879f-4a4f-ab13-408653237603.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NTc2MTEsIm5iZiI6MTcyNTU1NzMxMSwicGF0aCI6Ii8yNTgzOTI0Ni8zNDc4NjIxMDUtMzlkNzYwN2ItODc5Zi00YTRmLWFiMTMtNDA4NjUzMjM3NjAzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDE3MjgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkN2ZlYTZmY2JkYWY2YzBhY2E2YWVmYzk2NmY2YTI4NWU5YTJhNmM0ZTlmYjJiYmNhOTMzYmI0ZTU2YzdlN2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.f1yexXHt2UhkwU3auT258TmSBOyWm-vfKhn7hTwcRWM)
with this setup
and the following enum extension:
I would correct this by simply removing the remark, since it's (clearly) not utilized.
The text was updated successfully, but these errors were encountered: