Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 0.5px on drive cell models #8017

Closed
RuiXuqi opened this issue Jul 8, 2024 · 2 comments · Fixed by #8093
Closed

Missing 0.5px on drive cell models #8017

RuiXuqi opened this issue Jul 8, 2024 · 2 comments · Fixed by #8093
Labels
bug Self explanatory?

Comments

@RuiXuqi
Copy link

RuiXuqi commented Jul 8, 2024

Describe the bug

image
image
The cell models miss 0.5px.

How to reproduce the bug

Place ME Drive and put any Storage Cells with model update into it

Expected behavior

Fill the gap with leds or cell backdrop

Additional details

No response

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

https://pastebin.com/mw9Atr4n

@RuiXuqi RuiXuqi added the bug Self explanatory? label Jul 8, 2024
@Mithi83
Copy link
Contributor

Mithi83 commented Jul 18, 2024

The status LED ist rendered by the code. In the base texture the pixel is black. Since the code only paints over half of the bottom pixel you cannot have that pixel black in the base texture. I've tried to set that pixel to a copy of the top left pixel and that seems to work.

I can make a PR for that, but I'd like to hear @Ridanisaurus opinion first as I'm not an artist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Self explanatory?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants