Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent new processor textures #8007

Closed
Mithi83 opened this issue Jul 1, 2024 · 2 comments · Fixed by #8076
Closed

Inconsistent new processor textures #8007

Mithi83 opened this issue Jul 1, 2024 · 2 comments · Fixed by #8076
Labels
bug Self explanatory?

Comments

@Mithi83
Copy link
Contributor

Mithi83 commented Jul 1, 2024

Describe the bug

First of all: I love the new textures, also the fact that the individual processor types differ in shape rather than just color as before.

However while browsing EMI (or was it REI at that time?) I noticed some inconsistencies that I can't "un-see" now that I know of them. I compiled a little picture side-by-side of press, printed circuit and finished processor.

AE2 processors

  1. Notice that all presses have 3 pins (on different sides). This is inconsistent with the 2 pins on the calculation circuit and processor.
  2. Notice that the engineering press has pins on all 4 sides, while the engineering circuit and processor only have pins on 2 sides
  3. Notice that all presses have the same size, but the processors differ in size.
  4. Notice that the printed silicon has also a specific size that does not match the different processor sizes.

How to reproduce the bug

Look at the picture ;)

Expected behavior

Consistent textures or a statement that it is the way it should be (artistic freedom). To be honest: I have no good suggestion on how 3 and 4 could be addressed.

Additional details

No response

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

Selfcompiled main branch

@Mithi83 Mithi83 added the bug Self explanatory? label Jul 1, 2024
@Ridanisaurus
Copy link
Contributor

Ridanisaurus commented Jul 28, 2024

I was planning to update the Press textures a bit anyway to give them more unique identifiers at a quick glance, so this was perfect timing. Thank you for documenting it.
The only thing that remained the same is the Pressed Silicon. I can't think of a clean solution to make it match all 3 types at once while maintaining a unique shape for each Printed Circuit and Processor. This needs to be left to the imagination of players that it gets sheared off based on the final press to match the Processor.
image

@Mithi83
Copy link
Contributor Author

Mithi83 commented Jul 28, 2024

Wow, this is very detailed and looks so much more consistent, I like it. I think there is no clean solution for the silicon size but leaving that part to the imagination of the player (or creating a little background story for the lore) is fine. I find it more important that the player can easily identify which press must be used for which printed part when setting up the presses and that has been improved very well. Thanks!

@shartte shartte linked a pull request Jul 28, 2024 that will close this issue
shartte added a commit that referenced this issue Jul 28, 2024
- Updated the Press Textures to have a more unique visual to help
identify them at a quick glance #8007
- Updated the text offset when AE2 Button is in hover mode

---------

Co-authored-by: Sebastian Hartte <shartte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Self explanatory?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants