Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven integration #13

Closed
wants to merge 6 commits into from
Closed

Maven integration #13

wants to merge 6 commits into from

Conversation

tobias-
Copy link
Contributor

@tobias- tobias- commented Apr 2, 2014

Integration that lets you build the library (not the demo app).

Handles install properly, but not deploy, so extra maven config is needed for that.

@billmag
Copy link
Member

billmag commented Apr 2, 2014

I'd like to use 2 space tabs on this instead of tab characters, all of the other resources in our repository do so.

Also, I can probably merge the deploy configuration from our internal version of this project to fill this out. Any specific concerns you'd have with deployment?

@tobias-
Copy link
Contributor Author

tobias- commented Apr 2, 2014

Since we need to get the binary blob installed I do some hocus pocus in the root pom.xml, hence my concern for the deploying.

Right now we include appboy as a git subtree and build it together with the rest of our app, so we don't need deploy, but I assume most people will just want to build once and auto-deploy the .apklib and the .jar to a remote repository (or even just get a pre-built from a repository).

@billmag
Copy link
Member

billmag commented May 8, 2014

Quick note -- you can now install the UI library as an AAR into your local maven repository with ./gradlew install. If that satisfies your use case here, you can probably get rid of this pom file and close the pull request.

@tobias-
Copy link
Contributor Author

tobias- commented May 14, 2014

Ok, we're keeping it locally, but there's no point in this request anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants