Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recalculate line graph geometry if orientation has changed #156

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

danwood
Copy link

@danwood danwood commented Aug 18, 2020

Description

Get notified when the orientation changes to force re-calculation of line chart's layout.

Motivation and Context

Currently the line graph doesn't adapt to wider or narrower orientation when you rotate your iPhone/iPad. This change solves that.

How Has This Been Tested?

Tested on iPhone and iPad simulator.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (Updating Documentation, CI automation, etc..)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@AppPear AppPear merged commit ed01f53 into AppPear:new-version Aug 24, 2020
@danwood danwood deleted the orientation-change branch August 24, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants