Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for color extension #101

Merged

Conversation

AdrianBinDC
Copy link

Write unit tests

Description

  • Add unit tests for Color+Extension.swift

Motivation and Context

Add unit tests to facilitate automated testing and enable quick identification of breaking changes.

How Has This Been Tested?

Unit tests only, no changes to codebase.

Screenshots (if appropriate):

Screen Shot 2020-05-24 at 11 16 54 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (Updating Documentation, CI automation, etc..)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

- Wrote tests
- Possible minor bug where there's an alpha missing on 32-bit colors?
@AdrianBinDC AdrianBinDC force-pushed the unit-tests-for-color-extension branch from 87cfe8a to 0293ca7 Compare May 25, 2020 13:26
@AdrianBinDC
Copy link
Author

@AppPear I rebased off your new-version branch and resolved the conflict. All tests pass.

@AppPear AppPear merged commit 4963ec5 into AppPear:new-version May 26, 2020
@AppPear
Copy link
Owner

AppPear commented May 26, 2020

Thanks very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants