Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only notify ui of selection change if it actually changed #914

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Oct 8, 2024

Just a minor thing I noticed, if I have an empty node and I'm dragging horizontally, I could see the cursor blinking fast as if the selection updates all the time, but we shouldn't notify about the update unless the selection actually did change.

@Xazin Xazin merged commit 8eb1400 into AppFlowy-IO:main Oct 8, 2024
5 of 7 checks passed
@Xazin Xazin deleted the fix/pan-desktop-selection-update branch October 8, 2024 15:32
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (98356fa) to head (620322f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...t/service/selection/desktop_selection_service.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
- Coverage   71.94%   71.94%   -0.01%     
==========================================
  Files         318      318              
  Lines       14980    14981       +1     
==========================================
  Hits        10778    10778              
- Misses       4202     4203       +1     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant