Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove platform check in theme on web #91

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Apr 22, 2023

Closes: #89

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #91 (ef12ee5) into main (30f231a) will decrease coverage by 0.06%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   86.85%   86.80%   -0.06%     
==========================================
  Files         125      125              
  Lines        7374     7381       +7     
==========================================
+ Hits         6405     6407       +2     
- Misses        969      974       +5     
Impacted Files Coverage Δ
lib/src/service/shortcut_event/shortcut_event.dart 55.31% <0.00%> (-6.59%) ⬇️
lib/src/render/style/editor_style.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LucasXu0 LucasXu0 merged commit 32ffcf4 into AppFlowy-IO:main Apr 24, 2023
@LucasXu0
Copy link
Collaborator

To prevent this issue from happening again, we should also run our tests on the web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] runtime error on web - unsupported operation, Platform._operatingSystem
2 participants