Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode improvement #90

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

hyj1204
Copy link
Contributor

@hyj1204 hyj1204 commented Apr 20, 2023

  1. Add popupMenuFGColor for all the text and icon color used on the item's pop up menu
  2. Add popupMenuHoverColor for all the hover color used on the item's pop up menu
  3. Add a new clear icon to adapt to both light and dark mode
    image
    image

These changes mainly impact the following UIs

  1. Color pickers

image

  1. Link pop up menu

image

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #90 (00f0f8c) into main (0f303cb) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   86.79%   86.79%   -0.01%     
==========================================
  Files         124      124              
  Lines        7322     7337      +15     
==========================================
+ Hits         6355     6368      +13     
- Misses        967      969       +2     
Impacted Files Coverage Δ
lib/src/render/color_menu/color_picker.dart 96.12% <85.71%> (-1.52%) ⬇️
lib/src/render/link_menu/link_menu.dart 98.48% <92.85%> (-1.52%) ⬇️
lib/src/render/style/editor_style.dart 100.00% <100.00%> (ø)
lib/src/render/toolbar/toolbar_item.dart 94.07% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LucasXu0 LucasXu0 merged commit a864409 into AppFlowy-IO:main Apr 21, 2023
@hyj1204 hyj1204 deleted the feat/dark_mode_improvement branch April 21, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants