fix: backquote key will cause crash when using Frence IME #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasXu0
force-pushed
the
fix_backquote
branch
from
c3dcb6e
to
0340bb1
Compare
LucasXu0
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 72.40% 72.40% -0.01%
==========================================
Files 317 317
Lines 14785 14788 +3
==========================================
+ Hits 10705 10707 +2
- Misses 4080 4081 +1 ☔ View full report in Codecov by Sentry. |
LucasXu0
added a commit
to LucasXu0/appflowy-editor
that referenced
this pull request
Sep 17, 2024
…pFlowy-IO#892)" This reverts commit b888202.
LucasXu0
added a commit
that referenced
this pull request
Sep 17, 2024
LucasXu0
added a commit
to LucasXu0/appflowy-editor
that referenced
this pull request
Sep 20, 2024
* Revert "fix: backquote key will cause crash when using French IME (AppFlowy-IO#892)" This reverts commit b888202. * feat: support customizing max width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'`' in the French IME can trigger a character style convention. It can't be parsed as inline code in this case.
closes AppFlowy-IO/AppFlowy#5299