Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow configuring the auto scroll edge offset #888

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

snipd-min
Copy link
Contributor

When using the MobileFloatingToolbar with a markdown editor not in full screen design (e.g. if a docked footer is present on the screen), the default auto scroll edge might not work and would lead to the following assertion error:

  assert(
      globalRect.size.width >= _dragTargetRelatedToScrollOrigin.size.width &&
          globalRect.size.height >=
              _dragTargetRelatedToScrollOrigin.size.height,
      'Drag target size is larger than scrollable size, which may cause bouncing',
    );

In this case it might be useful to allow configuring the edge offset.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2024

CLA assistant check
All committers have signed the CLA.

@LucasXu0
Copy link
Collaborator

@snipd-min Thanks for contribution. Please sign the CLA :)

@snipd-min
Copy link
Contributor Author

Done :)

@LucasXu0 LucasXu0 merged commit ea494df into AppFlowy-IO:main Sep 16, 2024
7 of 9 checks passed
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.40%. Comparing base (5d1d311) to head (4d0ad39).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ditor_component/service/scroll_service_widget.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   72.40%   72.40%   -0.01%     
==========================================
  Files         317      317              
  Lines       14785    14787       +2     
==========================================
+ Hits        10705    10706       +1     
- Misses       4080     4081       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants