Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more link types #876

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

SillyCoon
Copy link
Contributor

According to AppFlowy-IO/AppFlowy#5146 I added support of mailto and file URIs.

It's also possible to use built-in Uri.tryParse to support any URI, but I'm not sure if this is a good idea since it allows any schema (e.g. javascript too) and probably should be validated more.

So for now I left it simple.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (b6bfd11) to head (f943c48).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/editor/util/link_util.dart 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   72.48%   72.48%           
=======================================
  Files         316      317    +1     
  Lines       14757    14771   +14     
=======================================
+ Hits        10696    10707   +11     
- Misses       4061     4064    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 changed the title feat: Support more link types feat: support more link types Sep 9, 2024
@LucasXu0 LucasXu0 merged commit 03bc9b4 into AppFlowy-IO:main Sep 9, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants