feat: optimize the table node parse steps and add logs #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zoli FYI, you may be interested in this PR. :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 72.56% 72.48% -0.09%
==========================================
Files 316 316
Lines 14732 14757 +25
==========================================
+ Hits 10690 10696 +6
- Misses 4042 4061 +19 ☔ View full report in Codecov by Sentry. |
zoli
reviewed
Sep 4, 2024
|
|
||
| for (var i = 0; i < colsCount; i++) { | ||
| if (node.children.length != colsLen * rowsLen) { |
There was a problem hiding this comment.
Why don't you just call validate on the node (maybe with some customization on the validate function)?
Thanks. I saw an issue regarding the table node the root of that problem hasn't been found yet. right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the assertion and forced unwrapping, make the code more production-friendly, and add more logging.