Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:chinese input #871

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

q200892907
Copy link
Contributor

Closed AppFlowy-IO/AppFlowy#6165
@LucasXu0 View records found to be handwritten input method can not input the solution to the problem deleted
I did not find this problem in the macos test, please inform me of the reason for deletion

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.56%. Comparing base (8e17d14) to head (70ab431).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   72.57%   72.56%   -0.02%     
==========================================
  Files         316      316              
  Lines       14723    14732       +9     
==========================================
+ Hits        10685    10690       +5     
- Misses       4038     4042       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Sep 3, 2024

@q200892907 Please check this PR. The major problem is that even when there's no composing text, the system still returns a valid one. I changed the shortcut enable logic.

Screenshot 2024-09-03 at 15 05 11

@LucasXu0 LucasXu0 merged commit 0b6b173 into AppFlowy-IO:main Sep 3, 2024
8 of 12 checks passed
@q200892907 q200892907 deleted the fix-chinese-input branch September 3, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Chinese input and deletion problems
2 participants