Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: underscore markdown syntax assertion #826

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

LucasXu0
Copy link
Collaborator

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: RangeError (end): Invalid value: Not in inclusive range 4..5: -1
#0      RangeError.checkValidRange (dart:core/errors.dart:365:9)
#1      _StringBase.substring (dart:core-patch/string_patch.dart:418:27)
#2      _OpIterator.next (package:appflowy_editor/src/core/document/text_delta.dart:591:23)
#3      Delta.compose (package:appflowy_editor/src/core/document/text_delta.dart:277:33)
#4      TextTransaction.compose.<anonymous closure> (package:appflowy_editor/src/core/transform/transaction.dart:568:59)
#5      ListBase.fold (dart:collection/list.dart:202:22)
#6      TextTransaction.compose (package:appflowy_editor/src/core/transform/transaction.dart:568:22)
#7      Transaction.operations (package:appflowy_editor/src/core/transform/transaction.dart:22:7)
#8      EditorState._applyTransactionInLocal (package:appflowy_editor/src/editor_state.dart:549:34)
#9      EditorState.apply (package:appflowy_editor/src/editor_state.dart:307:7)
#10     handleFormatByWrappingWithSingleCharacter (package:appflowy_editor/src/editor/editor_component/service/shortcuts/character/format_single_character/format_single_character.dart:107:15)
#11     formatUnderscoreToItalic.<anonymous closure> (package:appflowy_editor/src/editor/editor_component/service/shortcuts/character/format_single_character/format_italic.dart:17:35)
#12     executeCharacterShortcutEvent (package:appflowy_editor/src/editor/editor_component/service/ime/character_shortcut_event_helper.dart:14:36)
<asynchronous suspension>
#13     onInsert (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_on_insert_impl.dart:16:21)
<asynchronous suspension>
#14     KeyboardServiceWidgetState.initState.<anonymous closure> (package:appflowy_editor/src/editor/editor_component/service/keyboard_service_widget.dart:65:38)
<asynchronous suspension>
#15     NonDeltaTextInputService.apply (package:appflowy_editor/src/editor/editor_component/service/ime/non_delta_input_service.dart:49:9)
<asynchronous suspension>

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (98a49ad) to head (109ced9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   74.85%   74.79%   -0.07%     
==========================================
  Files         301      301              
  Lines       14204    14199       -5     
==========================================
- Hits        10633    10620      -13     
- Misses       3571     3579       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit d6388a4 into AppFlowy-IO:main Jun 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant