fix: content jumping down and scrolling getting locked. #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 74.80% 74.73% -0.07%
==========================================
Files 301 301
Lines 14198 14192 -6
==========================================
- Hits 10621 10607 -14
- Misses 3577 3585 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves: #5491
jumpTo()call. This can be removed since, making a selection implicitly causes the editor to scroll to the new selection.Preview:
For given user sample (small text)
https://github.com/AppFlowy-IO/appflowy-editor/assets/47064215/7c5093b7-6c08-4dd8-bbf5-9145a92cb40a
For long text sample
https://github.com/AppFlowy-IO/appflowy-editor/assets/47064215/d55713c1-991c-4e79-b053-23d632e58414
Additional Context:
AppFlowy-IO/AppFlowy#5491 (comment)