-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve mobile selection #776
feat: improve mobile selection #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it absolutely necessary to use updateSelection
? Will a editorState.updateSelectionWithReason
be good enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the collapsed handle for iOS on main or here, but I don't know why?
Using editorState.selection or editorState.updateSelectionWithReason are both OK.
In most cases, iOS does not feature a collapsed handle. iOS users can update a collapsed selection by long-pressing on it. @richardshiue By the way, the word count service test failed. |
Screen.Recording.2024-04-20.at.9.46.46.PM.mov
Screen.Recording.2024-04-20.at.9.20.28.PM.mov
Screen.Recording.2024-04-20.at.9.47.13.PM.mov
Screen.Recording.2024-04-20.at.9.21.30.PM.mov
Screen.Recording.2024-04-20.at.9.47.28.PM.mov
Screen.Recording.2024-04-20.at.9.22.09.PM.mov
Screen.Recording.2024-04-20.at.9.47.40.PM.mov
Screen.Recording.2024-04-20.at.9.21.01.PM.mov
Screen.Recording.2024-04-20.at.9.58.21.PM.mov