Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve ios touch gesture #648

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jan 5, 2024

  • Expand the long press gesture hit test area.
  • Adjust the selection gesture touch system to the new design.
zx.mp4

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 210 lines in your changes are missing coverage. Please review.

Comparison is base (07afd7a) 77.16% compared to head (cd6f9ff) 76.83%.

Files Patch % Lines
lib/src/render/selection/mobile_basic_handle.dart 0.00% 154 Missing ⚠️
.../src/render/selection/mobile_collapsed_handle.dart 0.00% 52 Missing ⚠️
...nt/service/selection/mobile_selection_service.dart 0.00% 2 Missing ⚠️
.../src/render/selection/mobile_selection_handle.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   77.16%   76.83%   -0.34%     
==========================================
  Files         291      293       +2     
  Lines       12931    12961      +30     
==========================================
- Hits         9978     9958      -20     
- Misses       2953     3003      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 7d2b456 into AppFlowy-IO:main Jan 5, 2024
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 8, 2024
* main:
  chore: bump version 2.2.0 (AppFlowy-IO#650)
  fix: android 14 issues (AppFlowy-IO#649)
  feat: improve ios touch gesture (AppFlowy-IO#648)
  feat: improve android selection gesture (AppFlowy-IO#647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant