Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input chinese issue #608

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

q200892907
Copy link
Contributor

Before

2023-11-28.15.17.11.mov

After

2023-11-28.15.17.37.mov

@q200892907
Copy link
Contributor Author

#576 bug fixed

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (af9f97e) 78.77% compared to head (9ec5f8a) 78.59%.
Report is 2 commits behind head on main.

Files Patch % Lines
...rvice/ime/delta_input_on_non_text_update_impl.dart 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   78.77%   78.59%   -0.19%     
==========================================
  Files         290      291       +1     
  Lines       12552    12586      +34     
==========================================
+ Hits         9888     9892       +4     
- Misses       2664     2694      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@q200892907 q200892907 closed this Nov 29, 2023
@q200892907 q200892907 reopened this Nov 29, 2023
@q200892907
Copy link
Contributor Author

q200892907 commented Nov 30, 2023

@LucasXu0
fixed #610
Tested on macos
There is no windows or linux environment, please test it

2023-11-30.14.13.44.mov

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Dec 4, 2023

@q200892907 Looks good. I will test it.

@LucasXu0 LucasXu0 merged commit 67e60ec into AppFlowy-IO:main Dec 7, 2023
8 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Dec 8, 2023
* main:
  fix: input chinese issue (AppFlowy-IO#608)
  fix: markdown does not support nested lists (AppFlowy-IO#611)
  chore: upgrade to flutter 3.16 (AppFlowy-IO#614)
  feat: support get the after text decorate from textSpanDecorator (AppFlowy-IO#612)
@q200892907 q200892907 deleted the fix-input_chinese_issue branch December 8, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants