feat: adding an ability to have a link check before embedding #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 78.66% 78.66% -0.01%
==========================================
Files 291 291
Lines 12569 12573 +4
==========================================
+ Hits 9888 9891 +3
- Misses 2681 2682 +1 ☔ View full report in Codecov by Sentry. |
LucasXu0
reviewed
Nov 27, 2023
|
Hi @LucasXu0 , I have resolved your feedback, are there any concerns or other feedback? Thank you very much. 🙌 |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Jan 4, 2024
* main: feat: table navigation using TAB key (AppFlowy-IO#627) feat: add markdown link syntax formatting (AppFlowy-IO#618) fix:text_decoration_mobile_toolbar_padding (AppFlowy-IO#621) fix: active hover on upload image (AppFlowy-IO#597) feat: adding an ability to have a link check before embedding (AppFlowy-IO#603) fix: node_iterator toList encounter Dangling Node trigger dead loop. (AppFlowy-IO#623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #382
Before
Screen.Recording.2023-11-23.at.15.08.42.mov
After
Screen.Recording.2023-11-23.at.15.02.05.mov