Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show magnifier when dragging the handlers #601

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

LucasXu0
Copy link
Collaborator

y.mp4

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (2ece948) 78.87% compared to head (ef6e484) 78.78%.

Files Patch % Lines
...component/service/selection/mobile_magnifiter.dart 0.00% 10 Missing ⚠️
...nt/service/selection/mobile_selection_service.dart 61.53% 5 Missing ⚠️
...or_component/service/selection_service_widget.dart 0.00% 1 Missing ⚠️
...bile_floating_toolbar/mobile_floating_toolbar.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   78.87%   78.78%   -0.10%     
==========================================
  Files         289      290       +1     
  Lines       12526    12551      +25     
==========================================
+ Hits         9880     9888       +8     
- Misses       2646     2663      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 7127a37 into AppFlowy-IO:main Nov 23, 2023
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Nov 23, 2023
* main:
  fix: floating toolbar position error (AppFlowy-IO#598)
  fix: selection menu positioning on right half of editor (AppFlowy-IO#600)
  feat: show magnifier when dragging the handlers (AppFlowy-IO#601)
  fix: editor cannot scroll when editable is false (AppFlowy-IO#599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant