Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle format on mobile #587

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

LucasXu0
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (50117b6) 80.49% compared to head (4602a2a) 80.38%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   80.49%   80.38%   -0.12%     
==========================================
  Files         286      286              
  Lines       12215    12228      +13     
==========================================
- Hits         9833     9829       -4     
- Misses       2382     2399      +17     
Files Coverage Δ
lib/src/editor/toolbar/mobile/mobile_toolbar.dart 89.69% <100.00%> (+0.10%) ⬆️
...src/editor/toolbar/mobile/mobile_toolbar_item.dart 100.00% <ø> (ø)
...mobile/toolbar_items/code_mobile_toolbar_item.dart 100.00% <100.00%> (ø)
...color/text_and_background_color_tool_bar_item.dart 100.00% <100.00%> (ø)
...ile/toolbar_items/divider_mobile_toolbar_item.dart 100.00% <100.00%> (ø)
...ile/toolbar_items/heading_mobile_toolbar_item.dart 100.00% <100.00%> (ø)
...mobile/toolbar_items/link_mobile_toolbar_item.dart 88.09% <100.00%> (+0.14%) ⬆️
...mobile/toolbar_items/list_mobile_toolbar_item.dart 100.00% <100.00%> (ø)
...obile/toolbar_items/quote_mobile_toolbar_item.dart 100.00% <100.00%> (ø)
...e/toolbar_items/todo_list_mobile_toolbar_item.dart 100.00% <100.00%> (ø)
... and 1 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 009115d into AppFlowy-IO:main Nov 13, 2023
10 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Nov 15, 2023
* main:
  fix: solve the left and right key bug.  (AppFlowy-IO#584)
  feat: toggle format on mobile (AppFlowy-IO#587)
  feat: support toggling format style when the selection is collapsed (AppFlowy-IO#586)
  chore: release 2.0.0-beta.1 (AppFlowy-IO#582)
  feat: support Flutter stable channel (AppFlowy-IO#581)

# Conflicts:
#	lib/src/editor/editor_component/service/ime/non_delta_input_service.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant