Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Checkbox unresponsive in custom Theme example in editor example app #543

Merged
merged 6 commits into from
Nov 5, 2023
Merged

feat: Checkbox unresponsive in custom Theme example in editor example app #543

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3aec657
feat: checkbox unresponsive custom theme example
johanzeroone Oct 18, 2023
7961475
Merge branch 'main' of https://github.com/AppFlowy-IO/appflowy-editor…
johanzeroone Oct 24, 2023
448b78b
Merge branch 'main' of https://github.com/AppFlowy-IO/appflowy-editor…
johanzeroone Nov 2, 2023
4b5e94d
fix: resolve feedback
johanzeroone Nov 2, 2023
71f928d
Merge branch 'main' of https://github.com/AppFlowy-IO/appflowy-editor…
johanzeroone Nov 2, 2023
f72e401
fix: change inkwell to gesture detector
johanzeroone Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions example/lib/pages/customize_theme_for_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,20 @@ class _CustomizeThemeForEditorState extends State<CustomizeThemeForEditor> {
configuration: configuration,
iconBuilder: (context, node) {
final checked = node.attributes[TodoListBlockKeys.checked] as bool;
return Icon(
checked ? Icons.check_box : Icons.check_box_outline_blank,
size: 20,
color: Colors.white,
return InkWell(
johansutrisno marked this conversation as resolved.
Show resolved Hide resolved
onTap: () async {
final state = await editorState;
final transaction = state.transaction
..updateNode(node, {
TodoListBlockKeys.checked: !checked,
});
state.apply(transaction);
johansutrisno marked this conversation as resolved.
Show resolved Hide resolved
},
child: Icon(
checked ? Icons.check_box : Icons.check_box_outline_blank,
size: 20,
color: Colors.white,
),
);
},
),
Expand Down
Loading