Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parsing the nested list when exporting the document to markdown format #540

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

LucasXu0
Copy link
Collaborator

from

Screenshot 2023-10-14 at 22 34 32 Screenshot 2023-10-14 at 22 34 35

to

Screenshot 2023-10-14 at 22 34 43

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d1027c4) 80.25% compared to head (0484c38) 80.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   80.25%   80.30%   +0.04%     
==========================================
  Files         282      282              
  Lines       12056    12061       +5     
==========================================
+ Hits         9675     9685      +10     
+ Misses       2381     2376       -5     
Files Coverage Δ
...ns/markdown/encoder/document_markdown_encoder.dart 100.00% <100.00%> (ø)
...down/encoder/parser/bulleted_list_node_parser.dart 100.00% <100.00%> (+10.00%) ⬆️
...arkdown/encoder/parser/code_block_node_parser.dart 90.90% <ø> (ø)
...s/markdown/encoder/parser/heading_node_parser.dart 100.00% <100.00%> (+8.33%) ⬆️
...ins/markdown/encoder/parser/image_node_parser.dart 100.00% <ø> (ø)
...c/plugins/markdown/encoder/parser/node_parser.dart 100.00% <ø> (ø)
...down/encoder/parser/numbered_list_node_parser.dart 100.00% <100.00%> (+10.00%) ⬆️
...ins/markdown/encoder/parser/table_node_parser.dart 100.00% <ø> (ø)
...gins/markdown/encoder/parser/text_node_parser.dart 100.00% <100.00%> (+12.50%) ⬆️
...markdown/encoder/parser/todo_list_node_parser.dart 100.00% <100.00%> (+8.33%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 9ae85ea into AppFlowy-IO:main Oct 14, 2023
11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 18, 2023
* main:
  feat: optimize editable features (AppFlowy-IO#541)
  feat: support parsing the nested list when exporting the document to markdown format (AppFlowy-IO#540)
  feat: add extra info parameter to node (AppFlowy-IO#539)
  feat: refactor logic for converting color string to Color in background_color_mixin.dart (AppFlowy-IO#538)
  feat: disable toolbar in code block
  fix: the icon of the quote block overflowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant