Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the selection should be clear if header or footer is focusing #525

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: the selection should be clear if header or footer is focusing #525

merged 1 commit into from
Oct 10, 2023

Conversation

LucasXu0
Copy link
Collaborator

closes #520

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (8bfd779) 80.32% compared to head (22559d3) 80.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   80.32%   80.16%   -0.16%     
==========================================
  Files         281      282       +1     
  Lines       11948    11971      +23     
==========================================
  Hits         9597     9597              
- Misses       2351     2374      +23
Files Coverage Δ
...t/service/selection/desktop_selection_service.dart 78.35% <0.00%> (-0.41%) ⬇️
...r/editor_component/entry/page_block_component.dart 91.48% <33.33%> (-8.52%) ⬇️
...t/base_component/widget/ignore_parent_gesture.dart 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 78b0045 into AppFlowy-IO:main Oct 10, 2023
9 of 11 checks passed
@LucasXu0 LucasXu0 mentioned this pull request Oct 10, 2023
Merged
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 12, 2023
@q200892907
Merge branch 'main' into feat-zhiya
35293be 
* main:
  fix: unable to clear the style by toggling twice (AppFlowy-IO#532)
  fix: pinyin IME on Linux (AppFlowy-IO#531)
  fix: background color issues (AppFlowy-IO#530)
  fix: cursor blink at wrong location when inserting text (AppFlowy-IO#529)
  feat: enable toggling and canceling of the formatting with shortcuts (AppFlowy-IO#528)
  chore: bump version 1.4.4 (AppFlowy-IO#527)
  fix: the selection handles remain on the screen after cutting the text (AppFlowy-IO#526)
  fix: the selection should be clear if header or footer is focusing (AppFlowy-IO#525)
  feat: customize desktop toolbar style (AppFlowy-IO#519)
  feat: add regex and case sensitive to `FindReplaceMenu` (AppFlowy-IO#480)
  feat: export JSON in mobile and update mobile_example.json (AppFlowy-IO#515)
  feat: support customizing error block (AppFlowy-IO#524)
  fix: impossible to click on any sub-items if the top level item is off-screen (AppFlowy-IO#522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] focus issue
1 participant
@LucasXu0