Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix web issues #498

Merged
merged 4 commits into from
Sep 24, 2023
Merged

fix web issues #498

merged 4 commits into from
Sep 24, 2023

Conversation

LucasXu0
Copy link
Collaborator

  • unable to input text on Web platform
  • focus will lost when typing slash
  • command shortcuts on the web platform should also respect the operating system

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 64.70% and project coverage change: +0.11% 🎉

Comparison is base (8e61846) 80.48% compared to head (04379e9) 80.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
+ Coverage   80.48%   80.59%   +0.11%     
==========================================
  Files         281      280       -1     
  Lines       11800    11768      -32     
==========================================
- Hits         9497     9485      -12     
+ Misses       2303     2283      -20     
Files Changed Coverage Δ
...tor_component/service/keyboard_service_widget.dart 87.60% <ø> (ø)
...component/service/ime/non_delta_input_service.dart 83.20% <50.00%> (ø)
lib/src/editor/util/platform_extension.dart 77.27% <58.33%> (-22.73%) ⬇️
...nent/service/shortcuts/command_shortcut_event.dart 69.23% <100.00%> (+3.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 82892aa into AppFlowy-IO:main Sep 24, 2023
10 of 11 checks passed
LucasXu0 added a commit that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant