Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve layout problem of FindMenuWidget #467

Merged
merged 6 commits into from
Sep 17, 2023
Merged

fix: resolve layout problem of FindMenuWidget #467

merged 6 commits into from
Sep 17, 2023

Conversation

sun-jiao
Copy link
Contributor

Close #464

@sun-jiao
Copy link
Contributor Author

This pr may conflict with #463 . I'll update the later merged branch to resolve possible conflicts with the earlier merged one.

@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (1944ab7) 80.42% compared to head (1c8a558) 80.45%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   80.42%   80.45%   +0.03%     
==========================================
  Files         281      281              
  Lines       11683    11698      +15     
==========================================
+ Hits         9396     9412      +16     
+ Misses       2287     2286       -1
Files Changed Coverage Δ
.../editor/find_replace_menu/find_replace_widget.dart 88.88% <100.00%> (+1.11%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sun-jiao
Copy link
Contributor Author

Surprisingly, there are no conflicts between the two branches that need to be resolved.

LucasXu0
LucasXu0 reviewed Sep 17, 2023
View reviewed changes
lib/src/editor/find_replace_menu/find_replace_widget.dart Outdated
@@ -175,6 +176,26 @@ class _FindMenuWidgetState extends State<FindMenuWidget> {
);
}

Widget _iconButton({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Widget instead of build function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean turn _iconButton to a new Widget class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasXu0 done.

@LucasXu0 LucasXu0 merged commit b65355f into AppFlowy-IO:main Sep 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasXu0 LucasXu0 LucasXu0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] FindMenuWidget throws _needsLayout.
2 participants
@sun-jiao @LucasXu0