Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table block bugs #431

Merged
merged 10 commits into from
Aug 31, 2023
Merged

fix: table block bugs #431

merged 10 commits into from
Aug 31, 2023

Commits on Aug 30, 2023

  1. fix: resizing the table won't send transaction

    @LucasXu0
    LucasXu0 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e585bff View commit details
    Browse the repository at this point in the history

  2. fix: lost selection after inserting table block

    @LucasXu0
    LucasXu0 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    978d881 View commit details
    Browse the repository at this point in the history

  3. fix: test

    @LucasXu0
    LucasXu0 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    830bb02 View commit details
    Browse the repository at this point in the history

  4. refactor: don't pass editorState to TableNode 

    pass only transaction to methods directly.
    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f260258 View commit details
    Browse the repository at this point in the history

  5. refactor: reduce extra transactions

    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    bd111b4 View commit details
    Browse the repository at this point in the history

  6. fix: mitigate Appflowy transaction adapter problem 

    With current transaction adapter in Appflowy which creates `BlockActionPB`
for `documentService` (backend). Its not possible to have multiple
`InsertOperation`s separately as a single transaction (multiple
`transaction.insertNode()`). The `BlockActionPB` creator (`toBlockAction`)
can't figure out the `prevId` (previous node of inserting node id), The
first insert operations shifts all next nodes path.
Because of this situation we decided to apply the insert operations one by
one.
    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    834079f View commit details
    Browse the repository at this point in the history

  7. fix: table actions keep selection

    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ae60deb View commit details
    Browse the repository at this point in the history

  8. fix: on add col|row respect row|col bg color

    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4be847e View commit details
    Browse the repository at this point in the history

  9. refactor: moving cell related keys to TableCellBlockKeys

    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    493ec1f View commit details
    Browse the repository at this point in the history

  10. style: dart format

    @zoli
    zoli committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    7cbf5ff View commit details
    Browse the repository at this point in the history