fix: add variable to hold editor selection for colour menu #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 80.78% 80.79% +0.01%
==========================================
Files 252 253 +1
Lines 10271 10284 +13
==========================================
+ Hits 8297 8309 +12
- Misses 1974 1975 +1
|
rileyhawk1417
changed the title
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Aug 28, 2023
* main: (48 commits) chore: comment suggesting use of deprecated method (AppFlowy-IO#417) fix: replace matches on the same node (AppFlowy-IO#418) fix: rect of the divider block is incorrect (AppFlowy-IO#415) chore: bump version 1.2.4 (AppFlowy-IO#414) feat: migrate copy paste command from AppFlowy (AppFlowy-IO#413) feat: added support for custom parser for markdown to document (AppFlowy-IO#403) feat: improve CJK IME support feat: add support for context menu items to the editor fix: refactor _onSelectionChange method to update _showPlaceholder state more efficiently fix: typo (AppFlowy-IO#408) Fix selected nodes (AppFlowy-IO#407) fix: miss the nested node when copying (AppFlowy-IO#406) feat: skip whitespace between words while navigating with CTRL+ARROW keys (AppFlowy-IO#363) feat: double hyphen to em dash (AppFlowy-IO#395) fix: add variable to hold editor selection for colour menu (AppFlowy-IO#400) test: open link command refactor: show link command test refactor: show link menu command feat: open link command fix: placeholder on paragraph when selected (AppFlowy-IO#390) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves issue #342
Adding a variable to hold the selection temporarily while the user chooses a custom colour solves the issue.
Since the focus would have moved from the editor onto the colour, that's how the selection was lost.