Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection reason should be ui event when clicking #359

Merged

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Aug 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #359 (dfa6392) into main (fbc1ecd) will increase coverage by 0.00%.
The diff coverage is 62.50%.

@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   75.97%   75.97%           
=======================================
  Files         247      247           
  Lines        9865     9866    +1     
=======================================
+ Hits         7495     7496    +1     
  Misses       2370     2370           
Files Changed Coverage Δ
...t/service/selection/desktop_selection_service.dart 81.61% <62.50%> (+0.06%) ⬆️

@LucasXu0 LucasXu0 merged commit ab10257 into AppFlowy-IO:main Aug 6, 2023
9 of 10 checks passed
@LucasXu0 LucasXu0 mentioned this pull request Aug 8, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Aug 8, 2023
* main:
  chore: release 1.2.3 (AppFlowy-IO#362)
  chore: format code
  Solve the problem of screen appearing at critical positions when there is a URL in the link menu (AppFlowy-IO#346)
  fix: selection menu respects current node direction (AppFlowy-IO#360)
  fix: show selection menu at left (AppFlowy-IO#361)
  fix: selection reason should be ui event when clicking (AppFlowy-IO#359)
  fix: desktop color picker issue

# Conflicts:
#	lib/src/editor/toolbar/desktop/items/link/link_toolbar_item.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant