-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: customized color options #270
Feat: customized color options #270
Conversation
@hyj1204 Please fix the CI issues. |
group: 4, | ||
isActive: onlyShowInTextType, | ||
builder: (context, editorState) { | ||
String? highlightColorHex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this ever get assigned any other value than null? Seems redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- make color options customized in Desktop - refactor mobile color options
ff49c2a
to
442a57c
Compare
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 63.68% 64.61% +0.92%
==========================================
Files 246 246
Lines 10878 10880 +2
==========================================
+ Hits 6928 7030 +102
+ Misses 3950 3850 -100
|
To close #234
Related to #211
To customize color options:
Desktop
Give a list of
ColorOption
tobuildTextColorItem
and/orbuildHighlightColorItem
functions to display your personalized colors.Mobile
Give a list of text/background
ColorOption
tobuildTextAndBackgroundColorMobileToolbarItem
to display your personalized colors.