Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep keyboard appearance as same brightness as system theme #264

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

hyj1204
Copy link
Contributor

@hyj1204 hyj1204 commented Jun 29, 2023

Fix #239

The keyboard appearance will use the same brightness(light or dark) as the current system theme.

@hyj1204 hyj1204 requested a review from LucasXu0 June 29, 2023 18:27
@hyj1204 hyj1204 self-assigned this Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #264 (2a7cd9a) into main (ed75bf6) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   62.41%   62.61%   +0.20%     
==========================================
  Files         246      246              
  Lines       10847    10857      +10     
==========================================
+ Hits         6770     6798      +28     
+ Misses       4077     4059      -18     
Impacted Files Coverage Δ
...tor_component/service/ime/delta_input_service.dart 0.00% <ø> (-0.81%) ⬇️
...component/service/ime/non_delta_input_service.dart 64.00% <ø> (+4.74%) ⬆️
...itor_component/service/ime/text_input_service.dart 100.00% <100.00%> (ø)
...tor_component/service/keyboard_service_widget.dart 88.03% <100.00%> (+0.20%) ⬆️

... and 16 files with indirect coverage changes

@LucasXu0 LucasXu0 force-pushed the fix/keyboard-issues-in-mobile branch from 88d52d0 to 2a7cd9a Compare July 3, 2023 03:19
@LucasXu0 LucasXu0 merged commit 8bfb37f into AppFlowy-IO:main Jul 3, 2023
@hyj1204 hyj1204 deleted the fix/keyboard-issues-in-mobile branch July 3, 2023 16:49
LucasXu0 pushed a commit to MayurSMahajan/appflowy-editor that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The keyboard is not dismissed when the navigator is popped.
2 participants