Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error occurs when applying divider on Mobile #252

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jun 25, 2023

closes #241

Two - will be connected on the mobile.

v.mp4

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #252 (a731b3e) into main (09fd4c8) will increase coverage by 0.00%.
The diff coverage is 31.25%.

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   63.67%   63.67%           
=======================================
  Files         240      240           
  Lines       10559    10562    +3     
=======================================
+ Hits         6723     6725    +2     
- Misses       3836     3837    +1     
Impacted Files Coverage Δ
...ponent/service/ime/delta_input_on_delete_impl.dart 0.00% <0.00%> (ø)
...tor_component/service/ime/delta_input_service.dart 58.87% <ø> (ø)
...er_block_component/divider_character_shortcut.dart 100.00% <100.00%> (ø)
...uote_block_component/quote_character_shortcut.dart 100.00% <100.00%> (ø)

@LucasXu0 LucasXu0 merged commit 60f45b5 into AppFlowy-IO:main Jun 25, 2023
zoli added a commit to zoli/appflowy-editor that referenced this pull request Jun 25, 2023
* main:
  fix: error occurs when applying divider on Mobile (AppFlowy-IO#252)
  feat: text and background color in mobile toolbar (AppFlowy-IO#233)
  fix: extend attribute keys shouldn't be sliced (AppFlowy-IO#248)
  feat: support customizing text attribute key and rendering (AppFlowy-IO#244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] An error occurs when applying divider markdown.
1 participant