Upload images from local files

[Mukund-Tandon]

fixes: #200

Screen.Recording.2023-06-21.at.3.26.37.PM.mov

[codecov]

Codecov Report

Merging #232 (c6267ee) into main (a1ae5ea) will decrease coverage by 0.23%.
The diff coverage is 43.65%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   62.63%   62.41%   -0.23%     
==========================================
  Files         243      246       +3     
  Lines       10772    10847      +75     
==========================================
+ Hits         6747     6770      +23     
- Misses       4025     4077      +52     

Impacted Files	Coverage Δ
..._component/image_block_component/base64_image.dart	0.00% <0.00%> (ø)
.../src/editor/util/file_picker/file_picker_impl.dart	0.00% <0.00%> (ø)
...c/editor/util/file_picker/file_picker_service.dart	0.00% <0.00%> (ø)
...t/image_block_component/image_block_component.dart	56.25% <42.85%> (-23.24%)	⬇️
...ent/image_block_component/image_upload_widget.dart	66.66% <49.15%> (-10.80%)	⬇️
...mponent/image_block_component/resizable_image.dart	52.77% <52.77%> (ø)
lib/src/infra/html_converter.dart	50.58% <66.66%> (-0.01%)	⬇️
lib/src/plugins/html/html_document_decoder.dart	82.91% <66.66%> (-0.43%)	⬇️

... and 1 file with indirect coverage changes

[LucasXu0]

Hey, @Mukund-Tandon Any updates?

[Mukund-Tandon]

Hey, @Mukund-Tandon Any updates?

I am working on it will sumbit a changes by tommorow, sorry for the delay

[LucasXu0]

@Mukund-Tandon Okay, just let me know if you need any help.

[Mukund-Tandon]

@LucasXu0 , please can you review this , I have made the UI changes and also handled the case where if the image is not found at its source it should display error. I am working on writing test for these.

Screen.Recording.2023-06-27.at.4.19.42.PM.mov

[LucasXu0]

Nice, I will check it out. Also, I plan to modify something on your branch.

[LucasXu0]

Suddenly, I have another idea to solve the deleted image problem. I plan to save the image value as base64, then we don't need to handle the error anymore.

Let me do that on your branch.

[LucasXu0]

FYI, @Mukund-Tandon. I have submitted the code. Please check them.

By the way, please rebase or merge the main branch as the pull request conflicts with it.

[Mukund-Tandon]

FYI, @Mukund-Tandon. I have submitted the code. Please check them.

By the way, please rebase or merge the main branch as the pull request conflicts with it.

Ok, I have updated my branch to resolve the merge conflicts .I will be now fixing some failing tests and will add more.

[LucasXu0]

@Mukund-Tandon Have you updated the branch? I didn't see any new commits.

[Mukund-Tandon]

@Mukund-Tandon Have you updated the branch? I didn't see any new commits.

Just pushed the changes 😅

[Mukund-Tandon]

@LucasXu0 ,I had a doubt, what is the use of the files under image(location - lib/src/render/image

[LucasXu0]

@Mukund-Tandon They're deprecated.

Are you working on fixing the tests? If not, I can do that.

[Mukund-Tandon]

@Mukund-Tandon They're deprecated.

Are you working on fixing the tests? If not, I can do that.

Yes I am working on the test, actually the tests of these files where only remaining failing test , so should I delete the test file of under image?

[LucasXu0]

No worries. Let me fix them.

[Mukund-Tandon]

No worries. Let me fix them.

Ok, so now should I proceed to work on other issues?

[LucasXu0]

No worries. Let me fix them.

Ok, so now should I proceed to work on other issues?

Yep. Just choose the issues you want to solve.

[Davidzhu001]

does it has a callback so i can upload image

[Mukund-Tandon]

does it has a callback so i can upload image

Hi, I don't completely understand your question, but we can upload an image from our local device as well as paste an image URL.

Screen.Recording.2023-08-01.at.1.42.41.PM.mov

Is there anything I am missing?

[Davidzhu001]

I am thinking if the user choose a image.
i can get the event and upload the image to my server.
then I got a url from the server. so i can call editorState.insertImageNode('');

or does the editor has a callback event, so i can listen when user choose a local image

[Davidzhu001]

when this button is clicked, is there event i can listen?

[D3vcode88]

Hello, the image upload on appflowy version 0.6.9 doesn't work, is it due to a bug? If it's not active yet, when will it be?
Is there an image integration service on appflowy, until this feature is available? @Mukund-Tandon