fix: toolbar position at most top #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasXu0
reviewed
Jun 20, 2023
| @@ -149,7 +149,9 @@ class _FloatingToolbarState extends State<FloatingToolbar> | |||
| } | |||
|
|
|||
| final rect = _findSuitableRect(rects); | |||
| print(rect); | |||
There was a problem hiding this comment.
please remove the print function
| final (top, left, right) = calculateToolbarOffset(rect); | ||
| print((top, left, right)); |
There was a problem hiding this comment.
Thanks for fixing them.
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 63.25% 63.28% +0.02%
==========================================
Files 228 228
Lines 10137 10139 +2
==========================================
+ Hits 6412 6416 +4
+ Misses 3725 3723 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At most top toolbar position goes out of the screen. Added a condition to check and position it on the bottom of the line.
appflowy-editor-toolbar-before-2023-06-20_00.16.11.mp4
appflowy-editor-toolbar-2023-06-20_00.17.40.mp4