Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile drag selection #209

Merged
merged 5 commits into from
Jun 20, 2023
Merged

mobile drag selection #209

merged 5 commits into from
Jun 20, 2023

Conversation

LucasXu0
Copy link
Collaborator

No description provided.

@LucasXu0 LucasXu0 marked this pull request as draft June 16, 2023 08:03
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #209 (e5dd210) into main (d2460c9) will decrease coverage by 0.79%.
The diff coverage is 0.43%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   63.08%   62.29%   -0.79%     
==========================================
  Files         228      230       +2     
  Lines       10082    10193     +111     
==========================================
- Hits         6360     6350      -10     
- Misses       3722     3843     +121     
Impacted Files Coverage Δ
...nt/service/selection/mobile_selection_service.dart 0.00% <0.00%> (ø)
...or_component/service/selection_service_widget.dart 62.50% <ø> (+2.97%) ⬆️
.../src/render/selection/mobile_selection_widget.dart 0.00% <0.00%> (ø)
...rc/service/selection/mobile_selection_gesture.dart 0.00% <0.00%> (ø)
lib/src/service/selection_service.dart 0.38% <ø> (ø)
...t/service/selection/desktop_selection_service.dart 69.69% <50.00%> (-0.96%) ⬇️

... and 1 file with indirect coverage changes

@LucasXu0
Copy link
Collaborator Author

demo.mp4

@LucasXu0 LucasXu0 marked this pull request as ready for review June 20, 2023 02:26
@LucasXu0 LucasXu0 merged commit 6e79060 into AppFlowy-IO:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant